Riverlea rollout - set Minetta as default, freeze previous default of Greenwich, sidestep DEFAULT_THEME - #31986
Closed
ufundo wants to merge 3 commits into
Closed
Riverlea rollout - set Minetta as default, freeze previous default of Greenwich, sidestep DEFAULT_THEME#31986ufundo wants to merge 3 commits into
ufundo wants to merge 3 commits into
Conversation
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
ufundo
force-pushed
the
riverlea-rollout-2
branch
from
February 7, 2025 10:31
83213c3 to
a3a737f
Compare
ufundo
marked this pull request as ready for review
February 7, 2025 10:34
ufundo
force-pushed
the
riverlea-rollout-2
branch
from
February 7, 2025 10:43
a3a737f to
8485364
Compare
Contributor
Author
|
Gods seem happy. How about you @totten ? |
Member
|
(This conversation is spread among three threads. Just noting that my main follow-up is on #31985.) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stop using Civi\Theme::DEFAULT_THEME , make Minetta the default at the settings level, switch upgraders to explicit Greenwich.
Alternative to #31979 based on wisdom of "[31979] swaps the hard-dependency in Civi\Core\Themes from greenwich to riverlea. I would tempted to relax that dependency"
Before
After
Technical Details
This leaves the DEFAULT_THEME code in, in the hope Test Gods dont notice what we're up to. But I would plan to remove that in a follow up.